Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing OSGi bundle + tycho-p2 build failures #9017

Merged
merged 4 commits into from
Dec 7, 2022
Merged

Fixing OSGi bundle + tycho-p2 build failures #9017

merged 4 commits into from
Dec 7, 2022

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Dec 6, 2022

Fix for warning (and occasional failure) of the build during jetty-p2 due to missing manifest headers.

[INFO] --- tycho-p2-repository-plugin:3.0.0:assemble-maven-repository (maven-p2-site) @ jetty-p2 ---

[WARNING] [18f8d83c-6508-4865-8b34-555866251936][plugin>org.eclipse.tycho:tycho-p2-repository-plugin:3.0.0] An error has occurred while adding 
the bundle /home/jenkins/agent/workspace/jetty.project_PR-9014/documentation/jetty-asciidoctor-extensions/target/jetty-asciidoctor-extensions-10.0.13-SNAPSHOT.jar.

org.osgi.framework.BundleException: Invalid manifest header Bundle-SymbolicName: ""

...

[WARNING] [18f8d83c-6508-4865-8b34-555866251936][plugin>org.eclipse.tycho:tycho-p2-repository-plugin:3.0.0] An error has occurred while adding 
the bundle /home/jenkins/agent/workspace/jetty.project_PR-9014/documentation/jetty-documentation/target/jetty-documentation-10.0.13-SNAPSHOT.jar.

org.osgi.framework.BundleException: Invalid manifest header Bundle-SymbolicName: ""

Signed-off-by: Joakim Erdfelt [email protected]

@joakime joakime added the Build label Dec 6, 2022
@joakime joakime added this to the 10.0.x milestone Dec 6, 2022
@joakime joakime requested a review from olamy December 6, 2022 22:56
@joakime joakime self-assigned this Dec 6, 2022
olamy
olamy previously approved these changes Dec 6, 2022
View reviewed changes
@olamy
Copy link
Member

olamy commented Dec 7, 2022

dohhh

Status ERROR: org.eclipse.equinox.p2.artifact.repository code=0 'void org.eclipse.equinox.internal.p2.repository.helpers.ChecksumProducer.<init>(java.lang.String, java.lang.String, java.lang.String)' java.lang.NoSuchMethodError: 'void org.eclipse.equinox.internal.p2.repository.helpers.ChecksumProducer.<init>(java.lang.String, java.lang.String, java.lang.String)'

Product publishing ended with the following exception:
java.lang.NoSuchMethodError: 'void org.eclipse.equinox.internal.p2.repository.helpers.ChecksumProducer.<init>(java.lang.String, java.lang.String, java.lang.String)'
	at org.eclipse.equinox.internal.p2.artifact.processors.checksum.ChecksumUtilities.calculateChecksums(ChecksumUtilities.java:124)

@olamy
Copy link
Member

olamy commented Dec 7, 2022

looks to be more some OSGI issues eclipse-tycho/tycho#1814

@olamy
Copy link
Member

olamy commented Dec 7, 2022

I just wonder if we should simply remove this plugin as even if using a fixed version of the plugin this can break for whatever reason!

janbartel
janbartel previously approved these changes Dec 7, 2022
View reviewed changes
@olamy olamy dismissed stale reviews from janbartel and themself via a244ec8 December 7, 2022 05:50
olamy
olamy previously approved these changes Dec 7, 2022
View reviewed changes
@joakime
Copy link
Contributor Author

joakime commented Dec 7, 2022

@olamy new error, trying to fix this one too.

[INFO] --- tycho-p2-repository-plugin:3.0.0:assemble-maven-repository (maven-p2-site) @ jetty-p2 ---
[ERROR] [93b6413b-c6ef-4bb1-b5ad-f5f04ab47384][plugin>org.eclipse.tycho:tycho-p2-repository-plugin:3.0.0] org.eclipse.tycho.p2.tools.impl
org.osgi.framework.BundleException: Could not resolve module: org.eclipse.tycho.p2.tools.impl [41]
  Unresolved requirement: Require-Bundle: org.eclipse.equinox.p2.director.app
    -> Bundle-SymbolicName: org.eclipse.equinox.p2.director.app; bundle-version="1.2.200.v20220802-0626"; tags:List<String>="osgi.connect"; singleton:="true"
       org.eclipse.equinox.p2.director.app [53]
         Unresolved requirement: Import-Package: org.eclipse.equinox.p2.core; version="[2.8.0,3.0.0)"

@joakime
Fixing version of p2.core
5b968ae 
Signed-off-by: Joakim Erdfelt <[email protected]>
@joakime joakime changed the title Fixing occasional error from maven-bundle-plugin Fixing OSGi bundle + tycho-p2 build failures Dec 7, 2022
@joakime joakime added the dependencies Pull requests that update a dependency file label Dec 7, 2022
olamy
olamy previously approved these changes Dec 7, 2022
View reviewed changes
@joakime joakime requested review from janbartel and olamy December 7, 2022 13:47
@jmcc0nn3ll jmcc0nn3ll self-requested a review December 7, 2022 13:49
jmcc0nn3ll
jmcc0nn3ll approved these changes Dec 7, 2022
View reviewed changes
Copy link
Contributor

@jmcc0nn3ll jmcc0nn3ll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@joakime joakime merged commit 3d3c954 into jetty-10.0.x Dec 7, 2022
@joakime joakime deleted the fix/jetty-10.0.x/documentation-bundle-plugin-warning branch December 7, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmcc0nn3ll jmcc0nn3ll jmcc0nn3ll approved these changes

@janbartel janbartel Awaiting requested review from janbartel

@olamy olamy Awaiting requested review from olamy

Assignees

@joakime joakime

Labels
Build dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
10.0.x
Development

Successfully merging this pull request may close these issues.
4 participants
@joakime @olamy @jmcc0nn3ll @janbartel